Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi-line strings in DeclareLaunchArgument #59

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix multi-line strings in DeclareLaunchArgument #59

merged 1 commit into from
Apr 15, 2024

Conversation

MatthijsBurgh
Copy link

@MatthijsBurgh MatthijsBurgh commented Mar 18, 2024 •
edited
Loading

This was referenced Mar 18, 2024
Merged
Merged
Closed
@MatthijsBurgh
Copy link
Author

Rolling industrial CI is broken. As it migrated to Noble. But no package have been released yet for Noble.

fmauch
fmauch reviewed Apr 15, 2024
View reviewed changes
Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. This indeed improves readability and has been forgotten since it had been initially created.

I think that's a good place to fix the mixed quotation style, as well, I've added suggestions for this.

ur_simulation_gazebo/launch/ur_sim_control.launch.py Show resolved Hide resolved
ur_simulation_gazebo/launch/ur_sim_moveit.launch.py Show resolved Hide resolved
@MatthijsBurgh
Copy link
Author

@fmauch Need approval for the CI again.

fmauch
fmauch approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@fmauch fmauch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks again @MatthijsBurgh . Will merge this once the non-ici jobs succeed.

Edit: Seems like the black formatter disagrees with my attempt to unify quotation styles.

@mergify mergify bot mentioned this pull request Apr 15, 2024
Merged
@fmauch fmauch merged commit a5e6a46 into UniversalRobots:ros2 Apr 15, 2024
7 of 15 checks passed
This was referenced Apr 15, 2024
Merged
Merged
Merged
@MatthijsBurgh MatthijsBurgh deleted the fix/declare_launch_argument branch April 16, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmauch fmauch fmauch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthijsBurgh @fmauch